Review main Merged

72200[BUGFIX] Fix undefined array key warning in ImageContentObject

Torben Hansen CR +2 V +2 Easy +1 −1 updated 11/17/21, 12:55

Commit message

Ensure the first argument passed to $this->cImage() is a
string if file is not defined in conf array.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 11/17/21, 07:44

  2. core-ci voted on patch set 1 V +1 11/17/21, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19389

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/17/21, 08:00

  4. Oliver Klee voted on patch set 1 CR +1 11/17/21, 12:37

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/17/21, 12:55

  6. Oli Bartsch merged patch set 2 11/17/21, 12:55