Review main Merged

72233[BUGFIX] Hide inline edit title button when user has no permissions

Jochen Roth CR +2 V +2 Normal +46 −16 updated 11/26/21, 23:12

Commit message

Currently the inline edit button is shown even though a
user does not have necessary edit permissions.

This has been fixed by adding the necessary checks.

As a side effect, the corresponding t3js class is no
longer added to the header for modules, not representing
an editable record title.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1321

  1. Jochen Roth uploaded patch set 1 11/18/21, 14:04

  2. core-ci voted on patch set 1 V +1 11/18/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19512

  3. Oli Bartsch commented on patch set 1 11/19/21, 19:21

    Could we fix this in recordlist as well?
  4. Jochen Roth uploaded patch set 2 11/22/21, 12:55

  5. Jochen Roth commented on patch set 2 11/22/21, 12:56

    Reply

    Thanks, fixed for recordlist.
  6. core-ci voted on patch set 2 V -1 11/22/21, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19629

  7. core-ci commented on patch set 2 11/22/21, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19629

  8. Jochen Roth uploaded patch set 3 11/22/21, 16:31

  9. core-ci voted on patch set 3 V -1 11/22/21, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19648

  10. core-ci commented on patch set 3 11/22/21, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19648

  11. Jochen Roth uploaded patch set 4 11/23/21, 10:54

  12. core-ci voted on patch set 4 V +1 11/23/21, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19669

  13. Oli Bartsch commented on patch set 4 CR -1 11/23/21, 11:40

    On it
  14. Oli Bartsch uploaded patch set 5 11/23/21, 12:17

  15. core-ci voted on patch set 5 V -1 11/23/21, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19672

  16. core-ci voted on patch set 5 V +1 11/23/21, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19672

  17. Jochen Roth voted on patch set 5 V +1 CR +1 11/23/21, 12:59

  18. Nikita Hovratov voted on patch set 5 V +1 CR +1 11/23/21, 14:04

  19. Benni Mack voted on patch set 5 V +1 CR +1 11/26/21, 22:50

  20. Oli Bartsch voted on patch set 5 V +2 CR +2 11/26/21, 23:12

  21. Oli Bartsch merged patch set 6 11/26/21, 23:12