Review 11.5 Merged

72266[BUGFIX] Do not use hardcoded field name for belayoutwizard

Oli Bartsch CR +2 V +2 Normal +60 −55 updated 11/24/21, 21:15

Commit message

TCA renderType=belayoutwizard did previously not
work for custom fields, as can be seen in styleguide
`tx_styleguide_elements_basic.text_20`.

BackendLayoutWizardElement used the hardcoded
field name "config", which however is only used for
the "backend_layout" table. Additionally, using the
raw database value instead of the processed
"itemFormElValue" led to further issues, e.g. when
the field is defined with "l10n_display=defaultAsReadonly".

This is now fixed by using the "itemFormElValue",
since this is the correct value, which is also added
to the corresponding input field and would also
contain the "default" for new records.

Additionally, the given parsed itemFormElValue is
now checked to start with the correct root level
key "backend_layout.". This prevents undefined
array key warnings, triggered when a malformed
default value is used for the field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. Oli Bartsch commented on patch set 1 11/24/21, 18:36

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 11/24/21, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19710

  3. core-ci commented on patch set 1 11/24/21, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19710

  4. core-ci voted on patch set 1 V +1 11/24/21, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19710

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/24/21, 21:15

  6. Oli Bartsch merged patch set 2 11/24/21, 21:15