72286[BUGFIX] Improve legacy handling of not Composer installed extensions
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Sybille Peters +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1720
-
Helmut Hummel uploaded patch set 1 11/25/21, 13:07
-
core-ci voted on patch set 1 V +1 11/25/21, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19735
-
Simon Gilli commented on patch set 1 CR +1 11/25/21, 20:34
-
Simon Gilli voted on patch set 1 V +1 11/25/21, 22:07
-
Benni Mack wrote 11/29/21, 10:20
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 14:06
-
Helmut Hummel commented on patch set 2 11/29/21, 15:07
PackageArtifactBuilder.php:301ReplyGood question. The idea back then was: "extensions, that are part of the root package (and not installed via Composer)" -
Simon Gilli voted on patch set 2 V +1 CR +1 11/29/21, 16:16
-
core-ci voted on patch set 2 V -1 11/29/21, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20086
-
Stefan Bürk rebased onto patch set 3 12/01/21, 20:27
-
core-ci voted on patch set 3 V +1 12/01/21, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20362
-
Simon Gilli voted on patch set 3 V +1 CR +1 12/03/21, 13:06
-
Stefan Bürk commented on patch set 3 12/03/21, 13:09
Would be nice if Sybille could verify it is working for here now - if I'm right she was the origin for creating that issue and the fix. -
Helmut Hummel commented on patch set 3 12/03/21, 16:26
Reply
Yeah, makes sense! -
Sybille Peters commented on patch set 3 V +1 12/03/21, 19:44
Looks like this solves original problem from me though I am having a little difficulty reproducing it. I have one extension where I can still reproduce it and problem goes away if PackageArtifactBuilder.php is replaced with version from this patch. -
Stefan Bürk voted on patch set 3 V +1 CR +1 12/03/21, 20:21
-
Christian Kuhn voted on patch set 3 V +1 CR +1 12/03/21, 20:34
-
Helmut Hummel voted on patch set 3 V +2 CR +2 12/04/21, 10:24
-
Helmut Hummel commented on patch set 3 12/04/21, 10:24
Thanks everybody for the reviews! -
Helmut Hummel merged patch set 4 12/04/21, 10:24
PackageArtifactBuilder.php:301