Review main Merged

72291[DOCS] Add example for finisher option "recipients"

TYPO3com CR +2 V +2 Normal +38 −16 updated 06/23/22, 20:25

Commit message

The new option is explained here:
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.0/Featur
e-80420-AllowMultipleRecipientsInEmailFinisher.html

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2839

Show 1014 earlier messages
  1. TYPO3com uploaded patch set 1 11/26/21, 09:09

  2. core-ci voted on patch set 1 V +1 11/26/21, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19780

  3. Benni Mack wrote 11/29/21, 10:22

    Change destination moved from master to main
  4. Benni Mack updated the commit message in patch set 2 11/29/21, 14:11

  5. Benni Mack updated the commit message in patch set 3 12/09/21, 13:41

  6. Oli Bartsch commented on patch set 3 12/09/21, 13:45

    EmailToSender has to be adjusted as well.
  7. core-ci voted on patch set 3 V +1 12/09/21, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20863

  8. Lina Wolf commented on patch set 3 CR -1 12/10/21, 12:01

    working on this
  9. Lina Wolf uploaded patch set 4 12/10/21, 12:11

  10. Lina Wolf commented on patch set 4 V +1 CR +1 12/10/21, 12:14

    The syntax of the intersphinx links was wrong :ref:`the_link` not `:ref:the_link`. Max line width should be 80, rephrased sentences containing "now". Renderders ok and (the changes) without warnings.
  11. Lina Wolf commented on patch set 4 CR -1 12/10/21, 12:15

    Adjusting Email to receiver
  12. core-ci voted on patch set 4 V +1 12/10/21, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20933

  13. Lina Wolf uploaded patch set 5 12/10/21, 12:29

  14. Lina Wolf commented on patch set 5 V +1 CR +1 12/10/21, 12:33

    Reply

    Adjusted it
    Added the same parameters to EmailToSender and fixed the intersphinx links.
  1. core-ci voted on patch set 5 V +1 12/10/21, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20935

  2. Stefan Bürk updated the commit message in patch set 6 12/12/21, 23:56

  3. core-ci voted on patch set 6 V +1 12/13/21, 00:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21012

  4. Oli Bartsch commented on patch set 6 CR -1 12/13/21, 11:29

    Actually "recipientAddress" and "recipientName" can still be found at various places within the docs. Additionally, the commit message needs some cleanup, as it currently contains broken links and uncommon phrases like the "[THIS TEXT IS A COPY .."
  5. Lina Wolf uploaded patch set 7 06/22/22, 10:57

  6. Lina Wolf uploaded patch set 8 06/22/22, 10:59

  7. Lina Wolf uploaded patch set 9 06/22/22, 11:01

  8. core-ci voted on patch set 7 V +1 06/22/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28333

  9. Lina Wolf commented on patch set 9 V +1 CR +1 06/22/22, 11:06

    Rebased and merged, renders fine
  10. core-ci voted on patch set 8 V +1 06/22/22, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28334

  11. core-ci voted on patch set 9 V +1 06/22/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28335

  12. Lina Wolf updated the commit message in patch set 10 06/22/22, 11:10

  13. core-ci voted on patch set 10 V +1 06/22/22, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28336

  14. Lina Wolf voted on patch set 10 V +1 CR +1 06/22/22, 12:23

  15. Chris Müller voted on patch set 10 V +1 CR +1 06/22/22, 13:54

  16. Björn Jacob voted on patch set 10 V +1 CR +1 06/23/22, 09:06

  17. Björn Jacob commented on patch set 10 06/23/22, 09:07

    @lina any reason for not having it in the docs of v11?
  18. Jörg Bösche voted on patch set 10 CR +1 06/23/22, 13:40

  19. Nikita Hovratov uploaded patch set 11 06/23/22, 19:19

  20. Nikita Hovratov commented on patch set 11 V +1 CR +1 06/23/22, 19:19

    Reply

    done
  21. core-ci voted on patch set 11 V +1 06/23/22, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28364

  22. Björn Jacob commented on patch set 11 V +1 CR +1 06/23/22, 19:54

    Thx for taking care!
  23. Nikita Hovratov voted on patch set 11 V +2 CR +2 06/23/22, 19:56

  24. Nikita Hovratov merged patch set 12 06/23/22, 19:56

  25. Nikita Hovratov commented on patch set 12 06/23/22, 20:25

    Reply

    No problem! This needs to be backported first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74978 It was forgotten it seems.