Review main Merged

72350[BUGFIX] Show error when copying a content element fails

Robert Kärner CR +2 V +2 Easy +2 −2 updated 06/28/22, 08:59

Commit message

A PHP 8.0 undefined array key warning was preventing
the flash message in the backend from appearing.
This is fixed by adding a fallback to null.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Robert Kärner uploaded patch set 1 11/29/21, 11:27

  2. core-ci voted on patch set 1 V +1 11/29/21, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19972

  3. Benni Mack commented on patch set 2 12/22/21, 12:53

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 12/22/21, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21396

  5. Jörg Bösche voted on patch set 2 CR +1 06/24/22, 19:50

  6. Oliver Klee voted on patch set 2 CR +1 06/24/22, 20:10

  7. Robert Kärner voted on patch set 2 V +1 CR +1 06/27/22, 05:59

  8. Stefan Bürk commented on patch set 2 V +1 CR +1 06/27/22, 13:48

    crap - nearly got fooled. Thought has enough votes. Self-voting is discouraged @Robert Kärner.
  9. Robert Kärner commented on patch set 2 06/27/22, 13:58

    Reply

    Alright, noted. I've probably seen this elsewhere, and only did when someone else pushed a new patchset. I also verified that the fix is still working as intended.
  10. Robert Kärner voted on patch set 2 V 0 CR 0 06/27/22, 14:02

  11. Oliver Hader voted on patch set 2 CR +1 06/28/22, 08:56

  12. Oliver Hader voted on patch set 2 V +2 CR +2 06/28/22, 08:59

  13. Oliver Hader merged patch set 3 06/28/22, 08:59