Review main Merged Breaking

72388[!!!][TASK] Remove service getters in ModuleTemplate

Oli Bartsch CR +2 V +2 Easy +4 −24 updated 11/30/21, 09:25

Commit message

The methods getIconFactory() and getPageRenderer()
from ModuleTemplate are now removed, since they
exposed internal state, while hiding dependencies.

Those services have to be injected in the
corresponding controllers directly.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3