Review main Merged

72401[TASK] Raise typo3/cms-styleguide:~12.0@dev

Christian Kuhn CR +2 V +2 Easy +16 −11 updated 11/30/21, 18:16

Commit message

Switch to latest development version of styleguide
in core v12 for now, until v12 core matures
towards 12.0 and a first 12.0.0 styleguide tag
will be created.

composer req --dev typo3/cms-styleguide:~12.0@dev

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Helmut Hummel +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1927

Show 2 earlier messages
  1. Christian Kuhn uploaded patch set 1 11/30/21, 11:30

  2. Christian Kuhn commented on patch set 1 CR -2 11/30/21, 11:31

    need to see if this fixes nightly, too.
  1. core-ci voted on patch set 1 V -1 11/30/21, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20217

  2. core-ci commented on patch set 1 11/30/21, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20218

  3. Christian Kuhn uploaded patch set 2 11/30/21, 12:49

  4. Helmut Hummel commented on patch set 2 CR -1 11/30/21, 12:57

    Let me suggest an alternative here to requiring a named branch
  5. core-ci voted on patch set 2 V +1 11/30/21, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20232

  6. Helmut Hummel uploaded patch set 3 11/30/21, 13:49

  7. Christian Kuhn updated the commit message in patch set 4 11/30/21, 13:51

  8. core-ci voted on patch set 3 V -1 11/30/21, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20234

  9. core-ci voted on patch set 4 V +1 11/30/21, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20235

  10. Helmut Hummel voted on patch set 4 V +2 CR +2 11/30/21, 14:12

  11. Helmut Hummel commented on patch set 4 11/30/21, 14:59

    Reply

    Done
  12. core-ci commented on patch set 4 11/30/21, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20238

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 11/30/21, 15:32

  14. Christian Kuhn uploaded patch set 5 11/30/21, 15:33

  15. Helmut Hummel voted on patch set 5 V +2 CR +2 11/30/21, 15:34

  16. core-ci voted on patch set 5 V -1 11/30/21, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20242

  17. Christian Kuhn uploaded patch set 6 11/30/21, 16:16

  18. Helmut Hummel voted on patch set 6 V +2 CR +2 11/30/21, 16:58

  19. Oli Bartsch voted on patch set 6 V +1 CR +1 11/30/21, 16:59

  20. Christian Kuhn rebased onto patch set 7 11/30/21, 17:31

  21. Christian Kuhn voted on patch set 7 CR -2 11/30/21, 17:40

  22. Helmut Hummel voted on patch set 7 V +2 CR +2 11/30/21, 17:46

  23. core-ci voted on patch set 7 V +1 11/30/21, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20252

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 11/30/21, 18:16

  25. Christian Kuhn merged patch set 8 11/30/21, 18:16