72406[FOLLOWUP] Clean up branch aliases
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Helmut Hummel uploaded patch set 1 11/30/21, 18:15
-
Christian Kuhn commented on patch set 1 CR -2 11/30/21, 18:17
blocked until i'm *really* sure this gives no headaches in CI again. -
core-ci voted on patch set 1 V +1 11/30/21, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20256
-
Helmut Hummel commented on patch set 1 CR -2 12/03/21, 15:35
Seems like this does not prevent the version guesser to guess the version from the git branch -
Helmut Hummel uploaded patch set 2 12/03/21, 16:15
-
Helmut Hummel commented on patch set 1 CR 0 12/03/21, 16:20
Actually, this change works exactly like expected. When Composer does not find a version for a path repo package, it tries to guess the version for EACH of them individually, by executing a few git command. Setting the version explicitly, skips this guessing entirely. The root package version was is still guessed, but this was done only once and now is as well skipped, by just setting a fixed version number "1.0.0" (since the version number of the root package does not matter anyway). So this change for sure skips all git commands Composer previously executed when the env var COMPOSER_ROOT_VERSION was not set. In fact with the env var set, a few git commands were executes as well, which is now completely skipped. -
core-ci voted on patch set 2 V +1 12/03/21, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20515
-
Christian Kuhn voted on patch set 2 CR 0 12/03/21, 16:32
-
Christian Kuhn commented on patch set 2 V +1 CR +1 12/03/21, 17:22
Thanks for investigation Helmut! Let's bring it in and if still something happens, we'll see it quickly. -
Stefan Bürk voted on patch set 2 V +1 CR +1 12/03/21, 19:17
-
Christian Kuhn voted on patch set 2 V +2 CR +2 12/03/21, 19:18
-
Christian Kuhn merged patch set 3 12/03/21, 19:18