Review main Merged

72478[BUGFIX] Fix deprecated functionality in Doctrine DBAL 3.x API

Benni Mack CR +2 V +2 Hard +213 −142 updated 12/07/21, 11:40

Commit message

The past changes of migrating to Doctrine DBAL 3.x
had some flaws:

* Not all changes from Doctrine DBAL 3.x was applied
* core relies on various invalid interfaces and classes, so the
  return types were wrong (also Tests used the old Statement class)
* No explicit ->execute() and ->iterateAssociative() calls
  and fetchColumn() vs. fetchOne()
* added executeQuery() and executeStatement() to QueryBuilder
  decorator class

This change adapts most places to help in migrating to Doctrine DBAL
3.x for TYPO3 v12, but also avoids some unneeded deprecations for now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 42

Show 22 more files