Review main Merged Breaking

72485[!!!][TASK] Deny inline JavaScript in FormEngine's requireJsModules

Oliver Hader CR +2 V +2 Normal +84 −55 updated 01/12/22, 15:51

Commit message

Custom FormEngine components loading additional RequireJS modules
must use corresponding JavaScriptModuleInstruction instances to
declare modules and optional method invocations.

Assigning scalar values to FormEngine node section 'requireJsModules'
(e.g. used for arbitrary inline JavaScript callbacks) is not possible
anymore and will throw a LogicException.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4