Review main Merged

72506[TASK] Avoid runtime overriding GLOBALS in functional tests

Christian Kuhn CR +2 V +2 Hard +174 −497 updated 12/04/21, 14:50

Commit message

The InternalResponseContext class of the testing-framework
provides method withGlobalSettings() which can be used to
set arbitrary globals when executing a frontend sub request.

It is used in various tests to set some TYPO3_CONF_VARS.

The testing-framework already provides class property
$configurationToUseInTestInstance to set TYPO3_CONF_VARS
on a per test-case level.

The patch migrates tests towards this property and
avoids using an AdditionalConfiguration fixture file
that is also used to set some TYPO3_CONF_VARS.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 30

Show 10 more files