Review 11.5 Merged

72581[TASK] Simplify ErrorHandler code

Helmut Hummel CR +2 V +2 Easy +8 −16 updated 12/12/21, 12:11

Commit message

To decide whether an error should be handled by the ErrorHandler
or not, only three things must be taken into account.

1. The current error_reporting() level
2. Error levels that are ignored by configuration
3. Error level of the error that is just handled

When combining the first two (with logical and),
results in the error level for the errors
that should be handled at all.

When combining this with the error level of the
currently handled error (again with logical and),
we can determine wether the error should be handled or not.

This always works with any PHP version and with suppressed
errors and without.

Therefore the PHP version check becomes obsolete and is removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1