Review 11.5 Merged

72589[BUGFIX] Fix array access warnings in EditDocumentController

Benni Mack CR +2 V +2 Easy +1 −1 updated 12/13/21, 14:55

Commit message

$this->firstEl is checked for !== null several times in
EditDocumentController, but it most certainly isn't, because
reset() returns false instead of null, if the array is empty.

This patch resolves this problem by setting $this->firstEl to
null, if reset($this->elementsData) returned false.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 12/13/21, 14:10

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 12/13/21, 14:17

  3. core-ci voted on patch set 1 V +1 12/13/21, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21034

  4. Benni Mack voted on patch set 1 V +2 CR +2 12/13/21, 14:55

  5. Benni Mack merged patch set 2 12/13/21, 14:55