Review main Abandoned

72622[TASK] Update yarn to v3

Jochen Roth CR 0 V 0 Impossible +12657 −7884 updated 07/12/22, 09:30

Commit message

Currently yarn 1.22.5 is used which is fairly outdated.

Yarn has been updated to v3.2.0.

Yarn (.yarnrc.yml->nodeLinker) is configured to create a
node-modules folder to ensure the scss imports
are working still.

Patches now reside in the "patches" folder but using
a different format and are now created using
"yarn patch <package>" and "yarn patch-commit <folder>".
"patch-package" is not required anymore because this
is now handled by yarn itself.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 18

Review log 5494

Show 3869 earlier messages
  1. Jochen Roth uploaded patch set 1 12/10/21, 13:28

  2. core-ci voted on patch set 1 V -1 12/10/21, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20940

  3. Benjamin Franzke commented on patch set 1 12/10/21, 14:12

    Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/72619 That patch should avoid using requirejs()
  4. Jochen Roth uploaded patch set 2 12/10/21, 14:16

  5. core-ci voted on patch set 2 V -1 12/10/21, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20943

  6. Jochen Roth uploaded patch set 3 12/10/21, 15:55

  7. core-ci voted on patch set 3 V -1 12/10/21, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20948

  8. Jochen Roth uploaded patch set 4 12/10/21, 16:34

  9. core-ci voted on patch set 4 V -1 12/10/21, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20950

  10. core-ci commented on patch set 4 12/10/21, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20950

  11. core-ci commented on patch set 4 12/10/21, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20950

  12. Jochen Roth uploaded patch set 5 12/11/21, 12:13

  13. core-ci voted on patch set 5 V +1 12/11/21, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20985

  14. Jochen Roth marked it work in progress 12/11/21, 13:27

  15. Jochen Roth uploaded patch set 6 12/12/21, 22:54

  16. Jochen Roth uploaded patch set 7 12/12/21, 22:55

  17. core-ci voted on patch set 6 V -1 12/12/21, 23:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21007

  18. core-ci voted on patch set 7 V +1 12/12/21, 23:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21008

  19. Jochen Roth uploaded patch set 8 12/12/21, 23:25

  20. Jochen Roth marked it ready for review 12/12/21, 23:26

  21. Jochen Roth updated the commit message in patch set 9 12/12/21, 23:36

  22. core-ci voted on patch set 8 V -1 12/12/21, 23:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21009

  23. Jochen Roth uploaded patch set 10 12/12/21, 23:42

  24. core-ci voted on patch set 9 V -1 12/12/21, 23:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21010

  25. core-ci voted on patch set 10 V +1 12/12/21, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21011

  26. Jochen Roth uploaded patch set 11 03/24/22, 12:14

  27. core-ci voted on patch set 11 V -1 03/24/22, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25095

  28. Jochen Roth uploaded patch set 12 03/24/22, 12:31

  29. core-ci voted on patch set 12 V -1 03/24/22, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25096

  30. Jochen Roth uploaded patch set 13 03/24/22, 12:50

  31. core-ci voted on patch set 13 V -1 03/24/22, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25097

  32. Oliver Klee commented on patch set 13 03/24/22, 14:18

    Can/should we update to 3.2 (which has released on February 20th https://github.com/yarnpkg/berry)?
  33. Jochen Roth uploaded patch set 14 03/24/22, 14:45

  34. Jochen Roth commented on patch set 14 03/24/22, 14:45

    Reply

    Done
  35. core-ci voted on patch set 14 V -1 03/24/22, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25100

  36. Oliver Klee wrote 03/24/22, 15:13

    Removed cc Oliver Klee.
  37. Jochen Roth uploaded patch set 15 03/24/22, 16:50

  38. Jochen Roth uploaded patch set 16 03/24/22, 16:55

  39. core-ci voted on patch set 15 V -1 03/24/22, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25104

  40. core-ci voted on patch set 16 V -1 03/24/22, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25106

  41. Benni Mack commented on patch set 16 03/24/22, 20:51

    how about we move the ts-ignore and type changes in a pre-patch?

    form-engine.ts:1243

    I think this needs to be kept as is. However, add a @ts-ignore on top
  42. Jochen Roth uploaded patch set 17 03/25/22, 13:52

  43. core-ci voted on patch set 17 V -1 03/25/22, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25139

  44. Jochen Roth uploaded patch set 18 03/25/22, 14:30

  45. Jochen Roth updated the commit message in patch set 19 03/25/22, 14:43

  46. Jochen Roth uploaded patch set 20 03/25/22, 14:53

  47. core-ci voted on patch set 18 V -1 03/25/22, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25141

  48. core-ci voted on patch set 19 V -1 03/25/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25142

  49. core-ci voted on patch set 20 V -1 03/25/22, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25144

  50. Jochen Roth uploaded patch set 21 03/28/22, 09:48

  51. core-ci voted on patch set 21 V -1 03/28/22, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25206

  52. Jochen Roth uploaded patch set 22 04/04/22, 14:16

  53. Jochen Roth uploaded patch set 23 04/04/22, 14:29

  54. core-ci voted on patch set 22 V -1 04/04/22, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25420

  55. core-ci voted on patch set 23 V -1 04/04/22, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25421

  56. Jochen Roth uploaded patch set 24 04/04/22, 17:20

  57. Jochen Roth uploaded patch set 25 04/04/22, 17:29

  58. core-ci voted on patch set 24 V -1 04/04/22, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25450

  59. core-ci voted on patch set 25 V -1 04/04/22, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25452

  60. Jochen Roth uploaded patch set 26 04/06/22, 18:04

  61. core-ci voted on patch set 26 V -1 04/06/22, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25692

  62. Jochen Roth uploaded patch set 27 04/10/22, 11:32

  63. core-ci voted on patch set 27 V -1 04/10/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25900

  64. Jochen Roth uploaded patch set 28 04/10/22, 14:09

  65. core-ci voted on patch set 28 V -1 04/10/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25903

  66. Jochen Roth uploaded patch set 29 04/10/22, 14:37

  67. core-ci voted on patch set 29 V -1 04/10/22, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25908

  68. Jochen Roth uploaded patch set 30 04/10/22, 20:58

  69. Jochen Roth uploaded patch set 31 04/10/22, 21:06

  1. core-ci voted on patch set 30 V -1 04/10/22, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25918

  2. Jochen Roth uploaded patch set 32 04/10/22, 21:16

  3. core-ci voted on patch set 31 V -1 04/10/22, 21:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25919

  4. core-ci voted on patch set 32 V -1 04/10/22, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25920

  5. Jochen Roth uploaded patch set 33 05/02/22, 18:21

  6. core-ci voted on patch set 33 V -1 05/02/22, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26743

  7. Jochen Roth uploaded patch set 34 05/02/22, 18:47

  8. core-ci voted on patch set 34 V +1 05/02/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26744

  9. Jochen Roth commented on patch set 34 05/02/22, 19:14

    This is ready for review now.

    form-engine.ts:1243 Reply

    Done
  10. Benjamin Franzke commented on patch set 34 CR -1 05/02/22, 20:01

    @types+jquery+2.0.47.patch:13

    It is important that this patch is kept, as it ensured that we retrieve build errors when missing to add jquery imports in TypeScript. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72646

    docker-compose.yml:4

    Why is this images switched in version (and vendor)?

    input-date-time-element.js:1

    Please remove, this file has been removed from TYPO3 core (was cached in your Build/JavaScript folder).

    ka.js:1

    Stray file?
  11. Jochen Roth uploaded patch set 35 05/03/22, 08:04

  12. core-ci voted on patch set 35 V +1 05/03/22, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26758

  13. Benjamin Franzke commented on patch set 35 CR -1 05/03/22, 08:16

    @types+jquery+2.0.47.patch:13 Reply

    The one still applies

    docker-compose.yml:4 Reply

    Done

    input-date-time-element.js:1 Reply

    Done

    ka.js:1 Reply

    Done
  14. Jochen Roth uploaded patch set 36 05/03/22, 08:29

  15. Jochen Roth uploaded patch set 37 05/03/22, 08:32

  16. Jochen Roth commented on patch set 37 05/03/22, 08:33

    docker-compose.yml:4 Reply

    Done, this was just for local testing on Mac M1

    input-date-time-element.js:1 Reply

    Done

    ka.js:1 Reply

    Ack
  17. core-ci voted on patch set 36 V -1 05/03/22, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26759

  18. core-ci voted on patch set 37 V -1 05/03/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26760

  19. Jochen Roth uploaded patch set 38 05/03/22, 08:44

  20. core-ci voted on patch set 38 V +1 05/03/22, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26761

  21. Jochen Roth commented on patch set 38 05/03/22, 09:02

    Thanks for reviewing.

    @types+jquery+2.0.47.patch:13 Reply

    Added that patch again.
  22. Josef Glatz commented on patch set 38 V +1 CR +1 05/04/22, 08:44

    Works o-o-t-b. Tested it on M1, macOS like so: ``` cd Build nvm install v16.10 nvm use yarn install yarn build ``` Manually tested backend, but as there are no changes in the resulting files, the patch looks straight forward to me! If possible > add the commands used for the update of yarn (if possible)

    Unresolved

    What command(s) were used to upgrade yarn. We often added this information in commit, since we're doing this not that often. Would be nice to have
  23. Benjamin Franzke commented on patch set 38 05/04/22, 11:51

    Sorry, I know you already put a lot of work into this, but yarns behaviour is currently a blocker in my opinion. We need to introduce a dozen of hacks and patch @types/requirejs just because yarn v3 pulls in @types/node automatically, without any package depending on it. Why does it do so? It pulls in @types/keyv (which needs @types/node) for "keyv" which is needed by "got" which is needed by grunt-contrib-imagemin. So this "feels" like https://yarnpkg.com/api/modules/plugin_typescript.html is enabled, but it isn't: yarn plugin remove @yarnpkg/plugin-typescript ➤ YN0001: UsageError: @yarnpkg/plugin-typescript isn't referenced by the current configuration So currently I feel like we should either stay with yarn v1 or rethink to migrate to npm-ci. I mean, maybe it's just a bug? But I don't know where to start with yarn v3, I don't even find a proper way to debug the dependecy resolution to analyze it, also all the output is mangled/replaced so I have no clue what yarn v3 is doing.. It feels like a block box to me. I dont know… maybe you can with out why got pulls in @types/keyv + @types/node yarn why @types/node -R └─ typo3-cms@workspace:. └─ grunt-contrib-imagemin@npm:4.0.0 (via npm:^4.0.0) ├─ imagemin-gifsicle@npm:6.0.1 (via npm:^6.0.1) │ └─ gifsicle@npm:4.0.1 (via npm:^4.0.0) │ ├─ bin-build@npm:3.0.0 (via npm:^3.0.0) │ │ └─ download@npm:6.2.5 (via npm:^6.2.2) │ │ └─ got@npm:7.1.0 (via npm:^7.0.0) │ │ ├─ @types/keyv@npm:3.1.4 (via npm:^3.1.1) │ │ │ └─ @types/node@npm:17.0.23 (via npm:*) │ │ └─ @types/responselike@npm:1.0.0 (via npm:^1.0.0) │ │ └─ @types/node@npm:17.0.23 (via npm:*) │ └─ bin-wrapper@npm:4.1.0 (via npm:^4.0.0) │ └─ download@npm:7.1.0 (via npm:^7.1.0) │ └─ got@npm:8.3.2 (via npm:^8.3.1) │ ├─ @types/keyv@npm:3.1.4 (via npm:^3.1.1) │ └─ @types/responselike@npm:1.0.0 (via npm:^1.0.0) ├─ imagemin-jpegtran@npm:6.0.0 (via npm:^6.0.0) │ └─ jpegtran-bin@npm:4.0.0 (via npm:^4.0.0) │ ├─ bin-build@npm:3.0.0 (via npm:^3.0.0) │ └─ bin-wrapper@npm:4.1.0 (via npm:^4.0.0) └─ imagemin-optipng@npm:6.0.0 (via npm:^6.0.0) └─ optipng-bin@npm:5.1.0 (via npm:^5.0.0) ├─ bin-build@npm:3.0.0 (via npm:^3.0.0) └─ bin-wrapper@npm:4.1.0 (via npm:^4.0.0)
  24. Jochen Roth commented on patch set 38 05/05/22, 09:44

    As Stefan Bürk mentioned, we could get rid of having the yarn blob/binary in git using corepack (see https://yarnpkg.com/getting-started/install#install-corepack) This would require a node update to >= 16.10 (below it requires to install corepack globall using `npm i -g corepack`) Just saying. :-)
  25. Jochen Roth abandoned the change 07/12/22, 09:30

    A decision was made to go for NPM.