Review main Merged

72626[TASK] Re-enable jquery.autocomplete in grunt copy action

Benjamin Franzke CR +2 V +2 Normal +38 −22 updated 12/14/21, 10:04

Commit message

Add a patch file for jquery.autocomplete that contains
the custom TYPO3 patches added in #79938 and #70988.

Enable the grunt copy action to ensure that mass
package-upgrades like #92419 do not miss to update
our local fork. A non-applying patch will produce an
error during upgrade, while a local fork is silently
ignored.

Also, pin devbridge-autocomplete to the version that is actually used
(updated last time in #70988):

  yarn add devbridge-autocomplete@~1.3.0

The patch file has been generated via:

  cp typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery.autocomplete.js \
     Build/node_modules/devbridge-autocomplete/dist/jquery.autocomplete.js
  patch-package devbridge-autocomplete

Note: The version line change is removed and the indentation
(tabs vs spaces) is fixed, as it rather limits updatability,
therefore the resulting javascript file format is slightly changed.
No functional change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 5

Files 5