Review main Merged

72641[BUGFIX] Recognize correct tag name

Albrecht Köhnlein CR +2 V +2 Easy +23 −1 updated 04/16/23, 20:00

Commit message

The HTML parser failed to correctly detect single tags with closing `/`
and without white space, e.g. `<br/>`. The old tag name detection only
splitted the tag content by white spaces, which is not enough to
correctly find these valid tags. So the new way is to also remove
trailing slashes from the tag name.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1521

  1. Albrecht Köhnlein uploaded patch set 1 12/13/21, 12:03

  2. core-ci voted on patch set 1 V +1 12/13/21, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21024

  3. Benni Mack rebased onto patch set 2 V +1 04/14/23, 10:12

  4. Benni Mack updated the commit message in patch set 3 04/14/23, 10:12

  5. core-ci voted on patch set 3 V +1 04/14/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40604

  6. Oliver Klee commented on patch set 3 04/14/23, 11:02

    Could we cover this with a test?
  7. core-ci voted on patch set 2 V +1 04/14/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40603

  8. Stefan Bürk updated the commit message in patch set 4 V +1 04/14/23, 17:58

  9. core-ci voted on patch set 4 V +1 04/14/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40638

  10. Albrecht Köhnlein uploaded patch set 5 V +1 04/15/23, 16:14

  11. Albrecht Köhnlein commented on patch set 5 04/15/23, 16:15

    Reply

    I added a test. It fails when my modification in HtmlParser.php is missing.
  12. Oliver Klee commented on patch set 5 04/15/23, 16:17

    HtmlParserTest.php:152

    I propose stating the expected behavior in the test name. My suggestion: `htmlCleanerKeepsSingleTagsWithAndWithoutEndingSlashUnchanged`
  13. core-ci voted on patch set 5 V +1 04/15/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40679

  14. Oliver Klee commented on patch set 6 V +1 04/15/23, 16:22

    Published edit on patch set 5.
  15. Oliver Klee commented on patch set 6 04/15/23, 16:22

    HtmlParserTest.php:152 Reply

    Done
  16. Oliver Klee voted on patch set 6 V +1 CR +1 04/15/23, 16:22

  17. core-ci voted on patch set 6 V +1 04/15/23, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40680

  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 04/16/23, 14:31

  19. Stefan Bürk voted on patch set 6 CR -1 04/16/23, 19:49

  20. Stefan Bürk voted on patch set 6 V +2 CR +2 04/16/23, 20:00

  21. Stefan Bürk merged patch set 7 04/16/23, 20:00