72641[BUGFIX] Recognize correct tag name
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1521
-
Albrecht Köhnlein uploaded patch set 1 12/13/21, 12:03
-
core-ci voted on patch set 1 V +1 12/13/21, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21024
-
Benni Mack rebased onto patch set 2
V +104/14/23, 10:12 -
Benni Mack updated the commit message in patch set 3 04/14/23, 10:12
-
core-ci voted on patch set 3 V +1 04/14/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40604
-
Oliver Klee commented on patch set 3 04/14/23, 11:02
Could we cover this with a test? -
core-ci voted on patch set 2 V +1 04/14/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40603
-
Stefan Bürk updated the commit message in patch set 4
V +104/14/23, 17:58 -
core-ci voted on patch set 4 V +1 04/14/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40638
-
Albrecht Köhnlein uploaded patch set 5
V +104/15/23, 16:14 -
Albrecht Köhnlein commented on patch set 5 04/15/23, 16:15
Reply
I added a test. It fails when my modification in HtmlParser.php is missing. -
Oliver Klee commented on patch set 5 04/15/23, 16:17
HtmlParserTest.php:152I propose stating the expected behavior in the test name. My suggestion: `htmlCleanerKeepsSingleTagsWithAndWithoutEndingSlashUnchanged` -
core-ci voted on patch set 5 V +1 04/15/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40679
-
Oliver Klee commented on patch set 6
V +104/15/23, 16:22Published edit on patch set 5. -
Oliver Klee commented on patch set 6 04/15/23, 16:22
HtmlParserTest.php:152ReplyDone -
Oliver Klee voted on patch set 6 V +1 CR +1 04/15/23, 16:22
-
core-ci voted on patch set 6 V +1 04/15/23, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40680
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 04/16/23, 14:31
-
Stefan Bürk voted on patch set 6 CR -1 04/16/23, 19:49
-
Stefan Bürk voted on patch set 6 V +2 CR +2 04/16/23, 20:00
-
Stefan Bürk merged patch set 7 04/16/23, 20:00