Review main Abandoned

72658[BUGFIX] Avoid undefined global variable $TSFE in PageLinkBuilder

Chris Müller CR 0 V 0 Easy +1 −1 updated 12/22/21, 10:04

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Chris Müller uploaded patch set 1 12/14/21, 16:46

  2. Chris Müller updated the commit message in patch set 2 12/14/21, 16:57

  3. core-ci voted on patch set 1 V +1 12/14/21, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21099

  4. core-ci voted on patch set 2 V +1 12/14/21, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21102

  5. Oliver Klee voted on patch set 2 CR +1 12/14/21, 18:53

  6. Benni Mack commented on patch set 2 12/14/21, 19:51

    PageLinkBuilder.php:414 Unresolved

    look two lines further ;)
  7. Benni Mack commented on patch set 2 12/22/21, 10:04

    Issue has been fixed yesterday in main + 11.5 will abandon this change now
  8. Benni Mack abandoned the change 12/22/21, 10:04

    Issue has been fixed yesterday in main + 11.5 will abandon this change now