Review main Abandoned

72668[TASK] Performance optimization for LiveSearch

Stefan Froemken CR 0 V 0 Normal +115 −21 updated 07/07/23, 12:28

Commit message

for columns that are case insensitive we now use a
performance optimized SQL query. For columns that are
case sensitive or configured in TCA as
['search']['case'] = true we still use the slightly slower
SQL query with LOWER().

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 58

  1. Stefan Froemken uploaded patch set 1 12/15/21, 20:34

  2. core-ci voted on patch set 1 V -1 12/15/21, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21149

  3. Stefan Froemken uploaded patch set 2 12/15/21, 21:37

  4. core-ci voted on patch set 2 V -1 12/15/21, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21153

  5. Benni Mack updated the commit message in patch set 3 V -1 05/03/23, 09:04

  6. core-ci voted on patch set 3 V -1 05/03/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41376

  7. Stefan Froemken uploaded patch set 4 V -1 07/07/23, 12:14

  8. Stefan Froemken abandoned the change 07/07/23, 12:28

    It is still true, that the query with LOWER() is always slower that without. But on a table with 60.000 records the performance difference is 0,003 seconds. That's not a real benefit.