Review main Merged Breaking

72671[!!!][TASK] Declare all ViewHelpers final

Christian Kuhn CR +2 V +2 Hard +206 −258 updated 12/17/21, 09:14

Commit message

As anticipated in v11 with #95298, this patch
declares ViewHelper classes PHP final, third party
extensions can no longer extend core ViewHelpers.

There is one exception: The ext:fluid FormViewHelper,
which is currently extended by ext:form. This can't
be resolved easily since it's on one hand quite a bit
of code that would have to be copied, and more importantly,
the FormField* ViewHelpers refer to the "parent"
FormViewHelper class name in various places. Declaring
FormViewHelper final thus needs a different refactoring,
which may be done in v12 with further patches.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 132

Show 112 more files