Review 11.5 Merged

72688[BUGFIX] Fix validation in form override settings

Benni Mack CR +2 V +2 Normal +188 −2 updated 12/16/21, 23:03

Commit message

The FinisherOptionGenerator of the form extension
generates the data structure for the form setting
overrides on the fly. By doing so, it didn't make
a distinction between normal TCA fields and flexform
specific sections/containers and added the wrapper
"TCEforms" to sections as well, which broke the
validation in DataHandler for the fields inside the
container (E.g. the email field).

The patch checks if section is set to "true" and
adds the "TCEforms" key only for normal TCA field
configurations.

Unit tests have been added for the DataHandler
checkValue_flex_procInData_travDS method, which
show cases with and without the "TCEforms" key.

Also, since this works now, a PHP 8 warning
appeared. This is fixed now, too.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3