72695[BUGFIX] Fix PHP 8 strict warning in Package MetaData
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Markus Klein +1
- Simon Gilli +1
- Stefan Bürk +1
-
Verified V +2 Done
- Helmut Hummel +2
- Markus Klein +1
- Simon Gilli +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2427
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 12/16/21, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21188
-
Simon Gilli voted on patch set 1 V +1 12/16/21, 15:35
-
Simon Schaufelberger commented on patch set 1 12/16/21, 16:18
-
Simon Schaufelberger commented on patch set 1 CR -1 12/16/21, 16:21
MetaData.php:43ReplyI have only found this: https://docs.phpdoc.org/latest/guide/guides/types.html#union-types -
Markus Klein commented on patch set 2 12/16/21, 21:55
Published edit on patch set 1. -
Markus Klein commented on patch set 2 12/16/21, 21:55
MetaData.php:43ReplyYes, must be string|null -
Markus Klein voted on patch set 2 V +1 CR +1 12/16/21, 21:55
-
core-ci voted on patch set 2 V +1 12/16/21, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21197
-
Helmut Hummel commented on patch set 2 12/17/21, 00:32
MetaData.php:43ReplyIt is a valid PHP type, how do you come to the assumption that PHP types are not allowed to be used in doc block? Yes, ?string is an alias of string|null but it does not make the first invalid. -
Markus Klein commented on patch set 2 12/17/21, 08:06
MetaData.php:43ReplyMy experience regarding this: - letting create phpstorm the docblock for a ?* type always creates it as *|null - doctrine annotator does not parse ?* correctly (extbase) Both can be seen as a deficiency of course. -
Simon Schaufelberger voted on patch set 2 CR +1 12/17/21, 09:01
-
Oliver Klee voted on patch set 2 CR +1 12/17/21, 10:24
-
Stefan Bürk commented on patch set 2 12/17/21, 14:18
I'm a little bit puzzled. Regarind the commit message, I would assume that strict typings are used. But that's not the case at all, neighter before or after. I would assume that this patch introduce or sets php types for method arguments, return types or properties .. so I do not get this. And have no real fealing about it. Thought if i should drop a comment or not .. maybe some can help me to understand it. -
Helmut Hummel commented on patch set 2 12/17/21, 14:56
MetaData.php:43ReplyI'm fine with string|null here. Was just wondering why this wouldn't work in a comment, but is a valid PHP type -
Helmut Hummel updated the commit message in patch set 3 12/17/21, 14:58
-
Helmut Hummel commented on patch set 3 12/17/21, 14:59
Reply
Better? -
Markus Klein voted on patch set 3 V +1 CR +1 12/17/21, 14:59
-
core-ci voted on patch set 3 V +1 12/17/21, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21214
-
Simon Gilli voted on patch set 3 V +1 CR +1 12/17/21, 15:33
-
Stefan Bürk voted on patch set 3 V +1 CR +1 12/17/21, 15:44
-
Helmut Hummel voted on patch set 3 V +2 CR +2 12/17/21, 15:58
-
Helmut Hummel merged patch set 4 12/17/21, 15:58
-
Simon Schaufelberger commented on patch set 4 12/17/21, 19:18
MetaDataTest.php:53Helmut, you missed this one. -
Markus Klein commented on patch set 4 12/17/21, 20:19
MetaDataTest.php:53ReplyActually it was me changing this. So I missed it, yes. -
Helmut Hummel commented on patch set 4 12/18/21, 15:11
MetaDataTest.php:53ReplyAck
MetaData.php:43