Review main Merged

72699[BUGFIX] Pass sanitized additional where as string in DatabaseRecordList

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 12/17/21, 14:48

Commit message

The RecordListGetTable hook allows to add an additional
where clause to the recordlist query. Since the sanitized
result was wrapped in an array before being passed to
$queryBuilder->andWhere(), this led to an exception.

This is now fixed by passing the sanitized clause as
string to `addWhere()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 12/17/21, 11:36

  2. Oli Bartsch updated the commit message in patch set 2 12/17/21, 11:38

  3. Oli Bartsch updated the commit message in patch set 3 12/17/21, 11:39

  4. core-ci voted on patch set 1 V +1 12/17/21, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21207

  5. core-ci voted on patch set 2 V +1 12/17/21, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21208

  6. core-ci voted on patch set 3 V +1 12/17/21, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21210

  7. Benni Mack voted on patch set 3 V +1 CR +1 12/17/21, 12:48

  8. Jochen Roth voted on patch set 3 V +1 CR +1 12/17/21, 13:19

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 12/17/21, 14:10

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 12/17/21, 14:48

  11. Oli Bartsch merged patch set 4 12/17/21, 14:48