Review main Abandoned

72711[BUGFIX] Do not track dependencies to Composer packages

Helmut Hummel CR -2 V 0 Normal +133 −23 updated 11/27/25, 11:37

Commit message

Do not add Composer dependencies to package meta data,
which drastically removes the size of the PackageArtifact.

At the same time, dependencies from TYPO3 framework
packages to third party extensions are removed,
to avoid cyclic dependencies during package ordering.

Review

  • Code review CR -2
    • Helmut Hummel -2
  • Verified V 0

Issues 1

Files 4

Review log 1825

  1. Helmut Hummel uploaded patch set 1 12/20/21, 00:40

  2. core-ci voted on patch set 1 V +1 12/20/21, 00:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21262

  3. Simon Gilli commented on patch set 1 V +1 12/20/21, 08:54

    Works with both cases, replace in the root and in an extension.
  4. Stefan Bürk commented on patch set 1 12/20/21, 14:57

    main missing ?
  5. Helmut Hummel uploaded patch set 2 04/03/22, 19:38

  6. Helmut Hummel uploaded patch set 3 04/03/22, 19:47

  7. core-ci voted on patch set 2 V +1 04/03/22, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25382

  8. Stefan Bürk commented on patch set 3 04/03/22, 19:48

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 04/03/22, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25383

  10. Oliver Klee updated the commit message in patch set 4 04/03/22, 22:47

  11. core-ci voted on patch set 4 V +1 04/03/22, 23:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25384

  12. Simon Gilli voted on patch set 4 CR +1 04/04/22, 06:13

  13. Simon Gilli commented on patch set 4 V +1 04/04/22, 06:55

    Great, I'm now able to replace the Symfony poly-fills with the root package, no more cycles!
  14. Andreas Kienast voted on patch set 4 CR +1 04/04/22, 07:16

  15. Helmut Hummel commented on patch set 4 CR -2 04/04/22, 12:42

    This does not fully solve the issues at hand unfortunately
  16. Helmut Hummel rebased onto patch set 5 08/10/22, 22:51

  17. core-ci voted on patch set 5 V -1 08/10/22, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30026

  18. Benni Mack updated the commit message in patch set 6 V -1 05/03/23, 09:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  19. core-ci voted on patch set 6 V -1 05/03/23, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41399

  20. Xavier Perseguers commented on patch set 6 07/12/23, 18:39

    Just wanted to comment on this. I still need to try but while starting the migration of a big project in TYPO3 v10 to v11, I got a segmentation fault with PHP 7.4.33, tested down to 7.4.9 and it always happened. The segfault happens while just trying to check syntax of `vendor/typo3/PackageArtifact.php`. Same file checked with PHP 8, no problem, same files with lots of removed extensions, no problem with PHP 7.4. Production running PHP 7.4.3 seems OK as well. `packageObjects` serialized object key is the culprit, somehow. After patching core with that patchset, no more segmentation fault. Now need to see whether it has other bad side effects but having a more lightweight `PackageArtifact.php` sounds good.
  21. Stefan Bürk uploaded patch set 7 V -1 07/12/23, 22:40

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  22. core-ci voted on patch set 7 V -1 07/12/23, 22:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44094

  23. Xavier Perseguers commented on patch set 7 V -1 07/13/23, 16:34

    Unresolved

    As said earlier, this patch solves my segmentation fault crash with PHP 7.4.9 to 7.4.33 on a big TYPO3 v11 project (no problem whatsoever with a "normal-size" project) due to the insanely large dependency serialization performed by the Core. HOWEVER, using this patch totally mess up the Backend login and the Backend altogether. Somehow the wrong CSS are loaded, possibly not in the correct order, ... So right now I need to find a solution to prevent that segfault that happens just by loading the new "PackageStates".
  24. Benni Mack updated the commit message in patch set 8 V -1 10/18/24, 14:10

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  25. Helmut Hummel abandoned the change 11/27/25, 11:37