Review 11.5 Merged

72720[BUGFIX] Remove useless string cast of idn_to_ascii()

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 12/20/21, 23:14

Commit message

The function `idn_to_ascii()` will return either `false` or a string,
the former one is returned on errors. In #93900, the result was cast to
string, making the check for `false` useless.

As `idn_to_ascii()` can return both, the string cast is removed to make
the check for `false` functional again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Oli Bartsch commented on patch set 1 12/20/21, 22:04

    Cherry Picked from branch main.
  2. Simon Schaufelberger voted on patch set 1 V +1 CR +1 12/20/21, 22:10

  3. core-ci voted on patch set 1 V +1 12/20/21, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21321

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 12/20/21, 23:14

  5. Oli Bartsch merged patch set 2 12/20/21, 23:14