Review main Merged

72735[BUGFIX] Fix scoping issue in FormEngineValidation

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 12/20/21, 14:37

Commit message

theChar is not initialized and therefore pollutes global scope.
(It is assigned to window.theChar in the FormEngine iframe).

Currently not an error (we are not using strict mode in RequireJS),
just bad style, but once we switch to strict mode (type="module"),
this will fail without proper declaration.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1