Review main Merged

72736[TASK] Prepare ImmediateActionElementTest for ES6 modules

Benjamin Franzke CR +2 V +2 Normal +32 −28 updated 12/20/21, 20:58

Commit message

In ES6 mode Viewport.Topbar and ModuleMenu.App properties
cannot be overwritten (in order to be substituted with a call spy),
as they reference other JavaScript modules.
The properties of ES6 models are readonly ("frozen") and can
therefore not be overwritten in a test setup.

Therefore the test is adapted to overwrite the references
in Viewport and ModuleMenu instead.

Also a timeout is added as await import('TYPO3/CMS/Backend/ModuleMenu')
does not guarantee a loading order between modules in ES6, which
causes test asserts to be executed too early.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2