Review main Merged

72758[TASK] Allow ServerRequestInterface in ext:fluid

Christian Kuhn CR +2 V +2 Expert +690 −572 updated 01/06/22, 14:47

Commit message

This changes StandaloneView and RenderingContext
to accept instances of ServerRequestInterface or
no Request at all - in contrast to extbase Request
only.

This is possible with extbase Request implementing
ServerRequestInterface since v11.

The patch changes a couple of ViewHelpers like the
often used TranslateViewHelper: It can run without
triggering extbase magic, which especially avoids the
performance wise awful ConfigurationManager. Further
patches will refactor backend views to leverage this.

Internal method RenderingContext->getUriBuilder()
is obsoleted and removed along the way.

This is a powerful change since it drops the last hard
dependency to extbase in fluid and allows views without
extbase being involved at all.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 24

Show 4 more files