Review main Merged

72768[TASK] Migrate FormEngine and FormEngineValidation to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +2253 −2184 updated 01/03/22, 16:14

Commit message

A human-readable diff of the applied changes can be inspected on:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.ts
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.ts

Notes:

 * No major refactoring to keep the diff minimal and prepare behaviour
   as-is
 * Map imports to require-style
 * Added default sections in switch statements
 * Guard parseInt and Date.parse with typeof/instanceof
 * Use event.eventTarget instead of this in jQuery event callbacks
 * Use second method parameter in jQuery.each callbacks
 * Add @ts-ignore and eslint-disable-next-line where TypeScript
   adaptions aren't possible without possibly changing behaviour

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 5