Review main Merged

72769[TASK] Add tests for list menu with folder as root storage

Benni Mack CR +2 V +2 Normal +69 −3 updated 12/23/21, 18:14

Commit message

This change adds test to document the behavior that excludeDoktypes
needs to be set to render folders in a menus as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Benni Mack uploaded patch set 1 12/22/21, 09:46

  2. core-ci voted on patch set 1 V +1 12/22/21, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21387

  3. Stefan Bürk commented on patch set 1 V +1 CR +1 12/22/21, 10:53

    Added test itself is okay.
  4. Stefan Bürk wrote 12/22/21, 11:44

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  5. Stefan Bürk wrote 12/22/21, 11:44

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  6. Stefan Bürk commented on patch set 1 CR -1 12/23/21, 15:18

    on it to add another testcase here
  7. Stefan Bürk uploaded patch set 2 12/23/21, 16:26

  8. core-ci voted on patch set 2 V +1 12/23/21, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21438

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 12/23/21, 16:45

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 12/23/21, 18:14

  11. Oli Bartsch merged patch set 3 12/23/21, 18:14