Review main Merged

72809[BUGFIX] Fix TCA of sys_workspace custom_stages

Nikita Hovratov CR +2 V +2 Easy +4 −1 updated 12/30/21, 13:22

Commit message

The TCA option "appearance" is an array, with
pre-defined configuration keys. The column
"custom_stages" of the table "sys_workspace" set a
csv value for this option. This does not work.

The configuration is now transformed into the
correct array format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Nikita Hovratov uploaded patch set 1 12/28/21, 16:41

  2. core-ci voted on patch set 1 V +1 12/28/21, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21482

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 12/28/21, 18:20

  4. Nikita Hovratov updated the commit message in patch set 2 12/29/21, 19:13

  5. core-ci voted on patch set 2 V +1 12/29/21, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21501

  6. Benni Mack voted on patch set 2 V +1 CR +1 12/29/21, 20:26

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 12/30/21, 13:12

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/30/21, 13:21

  9. Benni Mack merged patch set 3 12/30/21, 13:22