Review main Abandoned

72823[BUGFIX] Avoid undefined array key in inlineLocalizeSynchronize function of DataHandler

Johannes Seipelt CR 0 V 0 Easy +3 −3 updated 01/02/22, 18:33

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Johannes Seipelt uploaded patch set 1 01/02/22, 00:37

  2. core-ci voted on patch set 1 V +1 01/02/22, 00:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21543

  3. Chris Müller commented on patch set 1 01/02/22, 08:59

    Although this works I would prefer more type-aware fallbacks: $field = $command['field'] ?? ''; $language = $command['language'] ?? 0; $action = $command['action'] ?? '';
  4. Chris Müller commented on patch set 1 01/02/22, 09:00

    Unresolved

    Also please add "main" to the "Releases".
  5. Johannes Seipelt commented on patch set 1 01/02/22, 17:07

    Reply Unresolved

    was thinking about that aswell, but as this would be a bugfix for 11.5 i thought it might be better to not alter the behavior at all? up until now these would have been null? for main this would be the right thing
  6. Johannes Seipelt abandoned the change 01/02/22, 18:33