Review main Merged

72860[BUGFIX] Mark shortcut pages as active in HMENU

Benni Mack CR +2 V +2 Normal +191 −46 updated 01/05/22, 12:25

Commit message

This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 5