Review main Abandoned

72895[WIP][BUGFIX] Ensure ATagParams are overridden from global option

Benni Mack CR 0 V 0 Normal +128 −11 updated 01/06/22, 22:10

Commit message

This change mainly adds tests for showing that
the global TypoScript option

  config.ATagParams = tabindex="20"

can be used and any given attributes are actually
overridden if using typolink.ATagParams.

In addition, empty attributes such as "data-link"
can be added now as well.

@todo: the latter part should probably be separated
and added as a separate issue, as implodeAttributes()
and get_tag_attributes() have ZERO test coverage.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 23

  1. Benni Mack uploaded patch set 1 01/06/22, 21:53

  2. core-ci voted on patch set 1 V -1 01/06/22, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21737

  3. Benni Mack abandoned the change 01/06/22, 22:10

    will split this change