Review 10.4 Merged

72901[BUGFIX] Fix sprintf() PHP warning in FinisherOptionGenerator

Benjamin Franzke CR +2 V +2 Easy +4 −3 updated 01/07/22, 13:14

Commit message

User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more likely) %20S
(which is ' S' url escaped) may be contained and cause warnings
because sprintf() expects additional arguments in that case.

Streamline to always use the static '%s: "%s"' format instead.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1