Review 11.5 Merged

72918[BUGFIX] Prevent redirects causing infinite redirect loops

Benni Mack CR +2 V +2 Hard +620 −1 updated 01/07/22, 13:35

Commit message

This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corresponding frontend redirect middleware.

Furthermore, add a bunch of tests along the way to cover
this change and the different constellations, for example
not avoiding redirect with the same path but external host.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5