Review main Merged

72967[BUGFIX] Use proper regexp for Vimeo URLs in online media helper

Oliver Hader CR +2 V +2 Easy +3 −1 updated 01/11/22, 16:36

Commit message

The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` URLs as well. As a
result, the `video/` IDs were incorrectly resolved containing a
leading slash.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Jigal van Hemert +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Jigal van Hemert +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 01/11/22, 14:57

  2. Mathias Brodala voted on patch set 1 CR +1 01/11/22, 15:02

  3. Jigal van Hemert commented on patch set 1 V +1 CR +1 01/11/22, 15:09

    Works correctly now (tested on v10)
  4. core-ci voted on patch set 1 V +1 01/11/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21913

  5. Oliver Klee voted on patch set 1 CR +1 01/11/22, 15:39

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 01/11/22, 16:18

  7. Oliver Hader voted on patch set 1 V +2 CR +2 01/11/22, 16:36

  8. Oliver Hader merged patch set 2 01/11/22, 16:36