Review 10.4 Merged

72969[BUGFIX] Use proper regexp for Vimeo URLs in online media helper

Oliver Hader CR +2 V +2 Easy +3 −1 updated 01/11/22, 20:35

Commit message

The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` URLs as well. As a
result, the `video/` IDs were incorrectly resolved containing a
leading slash.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Jigal van Hemert +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Jigal van Hemert +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Hader uploaded patch set 1 01/11/22, 16:37

  2. Jigal van Hemert commented on patch set 1 V +1 CR +1 01/11/22, 16:38

    Thanks for the patch and backports!
  3. core-ci voted on patch set 1 V +1 01/11/22, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21919

  4. Oliver Hader voted on patch set 1 V +2 CR +2 01/11/22, 20:35

  5. Oliver Hader merged patch set 2 01/11/22, 20:35