Review main Merged

72995[FEATURE] Add timezone option to DateViewHelper

Georg Ringer CR +2 V +2 Normal +63 −0 updated 12/16/24, 08:21

Commit message

The argument `timezone´ can be used to render a date
with a different timezone.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1824

  1. Georg Ringer uploaded patch set 1 01/12/22, 11:03

  2. core-ci voted on patch set 1 V -1 01/12/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21961

  3. Georg Ringer uploaded patch set 2 01/12/22, 12:26

  4. core-ci voted on patch set 2 V +1 01/12/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21967

  5. Henrik Ziegenhain voted on patch set 2 CR +1 01/12/22, 13:18

  6. Georg Ringer commented on patch set 2 01/13/22, 10:47

    This change is ready for review.
  7. Christian Kuhn commented on patch set 2 CR -1 01/13/22, 18:27

    Date foo ;) It would be great to cover this with a functional test! That VH has tests already - should be do-able to add some more.
  8. Benni Mack commented on patch set 2 CR -1 01/13/22, 20:19

    DateViewHelper.php:164

    Calling setTimezone() never changes the actual "absolute", underlying, moment-in-time itself. It only changes the timezone you wish to "view" that moment "from". So in case you are using new \DateTime above with "2019-01-01 15:00" and then call ->setTimezone() afterwards, the time will be different, instead of adding the timezone at line 155 directly. This is the first of a looooong list of problems we're going to add, so we 100% need to be sure what the expected outcome is, and really have a long list of tests, so nobody will then break the expected outcome with followup patches
  9. Oliver Klee commented on patch set 2 07/16/23, 11:11

    How should we continue here?
  10. Stefan Bürk commented on patch set 2 07/17/23, 19:08

    Reply

    Some needs to write the well-covering tests. Still. Would keep it open .. maybe it finde someone to do that for v13 then.
  11. Oliver Klee wrote 08/25/24, 10:13

    Removed cc Oliver Klee.
  12. Benni Mack uploaded patch set 3 CR +1 V +1 12/10/24, 19:21

  13. core-ci voted on patch set 3 V -1 12/10/24, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70877

  14. Benni Mack uploaded patch set 4 V -1 12/11/24, 08:53

  15. Benni Mack commented on patch set 4 CR +1 V +1 12/11/24, 08:53

    DateViewHelper.php:164 Reply

    Done
  16. core-ci voted on patch set 4 V -1 12/11/24, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70898

  17. Benni Mack uploaded patch set 5 CR +1 V +1 12/11/24, 09:00

  18. core-ci voted on patch set 5 V +1 12/11/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70900

  19. Benni Mack voted on patch set 5 CR +1 V +1 12/11/24, 09:11

  20. Oli Bartsch uploaded patch set 6 CR +1 V +1 12/16/24, 08:13

  21. Oli Bartsch voted on patch set 6 CR +1 V +1 12/16/24, 08:13

  22. core-ci voted on patch set 6 V +1 12/16/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71163

  23. Benni Mack voted on patch set 6 CR +2 V +2 12/16/24, 08:21

  24. Benni Mack merged patch set 7 12/16/24, 08:21