72995[FEATURE] Add timezone option to DateViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1824
-
Georg Ringer uploaded patch set 1 01/12/22, 11:03
-
core-ci voted on patch set 1 V -1 01/12/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21961
-
Georg Ringer uploaded patch set 2 01/12/22, 12:26
-
core-ci voted on patch set 2 V +1 01/12/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21967
-
Henrik Ziegenhain voted on patch set 2 CR +1 01/12/22, 13:18
-
Georg Ringer commented on patch set 2 01/13/22, 10:47
This change is ready for review. -
Christian Kuhn commented on patch set 2 CR -1 01/13/22, 18:27
Date foo ;) It would be great to cover this with a functional test! That VH has tests already - should be do-able to add some more. -
Benni Mack commented on patch set 2 CR -1 01/13/22, 20:19
DateViewHelper.php:164Calling setTimezone() never changes the actual "absolute", underlying, moment-in-time itself. It only changes the timezone you wish to "view" that moment "from". So in case you are using new \DateTime above with "2019-01-01 15:00" and then call ->setTimezone() afterwards, the time will be different, instead of adding the timezone at line 155 directly. This is the first of a looooong list of problems we're going to add, so we 100% need to be sure what the expected outcome is, and really have a long list of tests, so nobody will then break the expected outcome with followup patches -
Oliver Klee commented on patch set 2 07/16/23, 11:11
How should we continue here? -
Stefan Bürk commented on patch set 2 07/17/23, 19:08
Reply
Some needs to write the well-covering tests. Still. Would keep it open .. maybe it finde someone to do that for v13 then. -
Oliver Klee wrote 08/25/24, 10:13
Removed cc Oliver Klee. -
Benni Mack uploaded patch set 3
CR +1V +112/10/24, 19:21 -
core-ci voted on patch set 3 V -1 12/10/24, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70877
-
Benni Mack uploaded patch set 4
V -112/11/24, 08:53 -
Benni Mack commented on patch set 4 CR +1 V +1 12/11/24, 08:53
DateViewHelper.php:164ReplyDone -
core-ci voted on patch set 4 V -1 12/11/24, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70898
-
Benni Mack uploaded patch set 5
CR +1V +112/11/24, 09:00 -
core-ci voted on patch set 5 V +1 12/11/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70900
-
Benni Mack voted on patch set 5 CR +1 V +1 12/11/24, 09:11
-
Oli Bartsch uploaded patch set 6
CR +1V +112/16/24, 08:13 -
Oli Bartsch voted on patch set 6 CR +1 V +1 12/16/24, 08:13
-
core-ci voted on patch set 6 V +1 12/16/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71163
-
Benni Mack voted on patch set 6 CR +2 V +2 12/16/24, 08:21
-
Benni Mack merged patch set 7 12/16/24, 08:21