Review main Merged Breaking

72997[!!!][TASK] Enforce non-empty configuration in cObj::parseFunc

Oliver Hader CR +2 V +2 Normal +159 −89 updated 01/21/22, 12:29

Commit message

Invoking ContentObjectRenderer::parseFunc without configuration
or TypoScript reference is not possible anymore and in general
did not make much sense.

Calling this method without any instructions led to various
side-effects, e.g. unintentionally enforcing typo3/html-sanitizer.
This problem was amplified when using <f:format.html parseFuncTSPath="">
with an explicitly empty reference which actually did not do anything
and behaved the same as <f:format.raw>.

This change enforces that parseFunc is only invoked with actual
instructions. An empty configuration will throw a LogicException and
requires corresponding source code or Fluid templates to be adjusted.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9