Review main Merged

73007[TASK] Modernize ext:lowlevel view

Christian Kuhn CR +2 V +2 Hard +407 −470 updated 01/13/22, 19:01

Commit message

This is a partial refactoring of ext:lowlevel. There
are some loose ends like HTML in the searchAction()
and some other details. Those might be target of a
bigger refactoring. However, the patch cleans up
controller and view and improves separation of
concerns already:

* Rename mainAction() to handleRequest()
* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Use DI in related controllers
* Switch from a ServiceProvider.php to casual Services.yaml
* Declare strict_types=1
* Return and property types in PHP classes
* PageRenderer JS module loading via fluid, not PHP
* f:translate with full LLL: keys

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 20