Review main Merged

73018[TASK] Page and info module events/hooks outside form tag

Christian Kuhn CR +2 V +2 Easy +13 −10 updated 01/14/22, 19:20

Commit message

The page module provides ModifyPageLayoutContentEvent
to add content before and/or after the main module content.
Extensions like ext:sys_note can use this to render own
content. Unfortunately, this content is *within* the
default page module form tag, which prevents extension
content to create own POST forms.

The patch changes the page module HTML slightly to
not encapsulate the event content within the form tag.

The same situation appears in info module "page information"
with "drawFooterHook". The situation here is worse, since
the main form tag is rendered by InfoModuleController and
not PageInformationController. This "module function"
construct in info module is still an ugly mess and really
needs an overhaul. For now, the patch adds a hack in
PageInformationController to close the outside form, then
adds the hook content, then opens another form for valid HTML.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 2