Review main Merged

73023[TASK] Clean up workspace module views

Christian Kuhn CR +2 V +2 Hard +277 −385 updated 07/28/25, 13:31

Commit message

* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Less class state
* Declare strict_types=1
* Return and property types in PHP classes
* Avoid a useless layout template
* f:translate with full LLL: keys
* Various code juggling to improve readability

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1216

  1. Christian Kuhn uploaded patch set 1 01/14/22, 21:34

  2. core-ci voted on patch set 1 V +1 01/14/22, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22096

  3. Christian Kuhn uploaded patch set 2 01/14/22, 21:50

  4. core-ci voted on patch set 2 V -1 01/14/22, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22098

  5. Christian Kuhn uploaded patch set 3 01/15/22, 09:52

  6. core-ci voted on patch set 3 V +1 01/15/22, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22116

  7. Christian Kuhn uploaded patch set 4 01/15/22, 10:35

  8. core-ci voted on patch set 4 V +1 01/15/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22117

  9. Benni Mack voted on patch set 4 V +1 CR +1 01/15/22, 14:44

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 01/15/22, 19:44

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 01/16/22, 07:13

  12. Christian Kuhn merged patch set 5 01/16/22, 07:13

  13. Benjamin Franzke commented on patch set 5 07/28/25, 11:22

    Index.html:21

    Hey, Sorry, I'm late to the party, but I think this is wrong: This implicit change has the drawback that workspace users can no longer get an overview of all changes of all webmounts (via the virtual root page uid=0) or administrators over all sites. The message is actually plain wrong, as it is displayed even if the user select the virtual page id=0. See https://forge.typo3.org/issues/95854 for an issue where we reported and fixed this usecase previously (3 months before this patch broke it again), after it regressed between v9 and v11 because of pagetree refactorings. This kind of change is too implicit for a "cleanup", this is behavioural change which we should at least discuss via explicit commit messages. This is really not just a cleanup. 😞 Why do I come up with this right now? I'm conceptually looking at our id=0 pages and think we should improve user guidance and not just prompt our users with one info-alert that states: > Please select a page in the page tree to review and publish changes. We can do better and show useful information, recent actions, whatever, and I thought: well, at least our workspaces can do that (in contrast to the page module), opened it and was immediately disappointed, because it lost this capability and degraded to the limited id=0 offerings of the Page module. I don't want to rant, I just want to raise awareness and ask to really thoroughly think about usecases of our users when "cleaning" up views…
  14. Benjamin Franzke commented on patch set 5 07/28/25, 11:48

  15. Benni Mack commented on patch set 5 07/28/25, 12:11

    Index.html:21 Reply

    tbh: To me this feels like a rant... Yes. 3.5 years ago, the commit message could have been better, but I wonder when/if somebody is up for discussing such things. From a UX perspective, the current situation is more consistent with the other modules now than before. Functionality was taken away, but UX-wise there is no clear decision what should happen on each module when pid=0 is selected. I personally dislike the "magic of pid=0" (also in e.g. list module). Hardly anybody care(d) about the workspace module for years - so much functionality was taken away since TYPO3 v8 (ExtJS migration) to have editors work effectively with this module - such as flexible column rendering. I am also wondering how we break things, aren't able to add visual tests for features such as the expand toggle for inline children, a feature was broken since jQuery was removed - this is a 100% mess. Commenting 3.5 years later on patches where cleaning up was done to improve the mess feels like a slap in the face for those who are aware of this mess. So we lack a process where somebody takes the time to give feedback on patches. Example: I have a patch pending for a long time (almost 11 months). https://review.typo3.org/c/Packages/TYPO3.CMS/+/86036 - it would allow us to use DI in LinkBuilders, reduce reliance on ContentObjectRenderer etc. I can sit this out, or find people to vote for it, or abandon it. Nonetheless, at the time of writing this patch I feel this is an improvement over the current situation. If I get feedback 3.5 years later after the merge, makes me really think of being motivated to contribute further in such areas. Two other areas that come to my mind where we lack clear direction of how editors are being steered: Linkvalidator module, Recycler module. So obviously, we need rules how to make decisions to "improve life for editors", other than that, we always get to the point where we have one opinion vs. the other.
  16. Benjamin Franzke commented on patch set 5 07/28/25, 13:31

    Index.html:21 Reply

    Ok, I actually would have never imagined that this is perceived as an "one opinion vs. the other" topic, since I'm referring to customer feedback and a regress in functionality here. Therefore I've written that I want to raise awareness for this usecase, since I simply thought this needs to be a oversight, as I thought no one would ever remove this on purpose. **I'm sorry that this is demotivating you.** But to be honest: I actually don't know how to change situations like these while keeping to be myself and trying to improve our product. Really, I even gave the bigger picture, *why* I'm getting to this old commit and shared my vision for id=0 overviews, I'm really puzzled how that could end up being interpreted as a rant. I mean, I even wrote "I don't want to rant", but still wanted to share my disappointment, which is human and something we should always allow each other, if it's presented in a polite way, which I tried… Again I could not imagine we could have different understandings of what's correct behaviour in this case. I imagined this usecase was just not well thought through back then, but I couldn't verify because lack of information in the commit message, Therefore I wrote my thoughts as a response here where all review participants get an unobtrusive notification and have full context without being directly distracted from work and feeling the need to answer (as opposed to slack messages).