Review main Merged

73026[TASK] Migrate Form Framework JavaScript and documentation to ES6

Benjamin Franzke CR +2 V +2 Expert +776 −301 updated 01/25/22, 10:30

Commit message

The module syntax is moved from AMD to ES6.
To avoid reindenting every javasscript line (>10000 LOC),
the existings factories are kept as-is and the exports
are spreaded from the factory result.

A new configuration option dynamicJavaScriptModules
is added to replace the previous dynamicRequireJsModules
functionality to incorparate for the new ES6 functionality
added in #96510 and #96511.

Also dynamicRequireJsModules is no longer passed to
the form editor and manager templates, as this variable
is a left over from #90867.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 26

Show 6 more files