Review main Abandoned

73036[BUGFIX] Avoid invalid locale for flatpickr JavaScript warning

Stefan Bürk CR 0 V 0 Easy +5 −2 updated 07/06/23, 14:34

Commit message

Initalizing DateTimePicker through the FormEngine in the backend
reads the current user settings (uc) using the PersistanceStorage
and corresponding ajax call to retrieve these dataset, grabbing
the 'lang' from it and initalizing flatpicker with it.

During core development without a custom saved user profile this
lang field is missing in the userconfig data, thus having 'undefined'
instead of an empty string for language, thus not fallbacking to
default language.

This patch handles a fallback to an empty string, thus using default
for flatpicker initalizations to avoid this warning in the browser
webconsole.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 69

  1. Stefan Bürk uploaded patch set 1 01/16/22, 19:56

  2. core-ci voted on patch set 1 V -1 01/16/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22153

  3. core-ci voted on patch set 1 V +1 01/16/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22153

  4. Stefan Bürk uploaded patch set 2 01/17/22, 01:11

  5. core-ci voted on patch set 2 V +1 01/17/22, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22162

  6. Christian Kuhn commented on patch set 2 CR -1 01/17/22, 19:16

    this is a bigger issue since 'current lang' selection is stored in a db field since https://review.typo3.org/c/Packages/TYPO3.CMS/+/68192 AND the change in behavior is a side effect of the php 8 sanitation in first hunk of https://review.typo3.org/c/Packages/TYPO3.CMS/+/68192/9/typo3/sysext/setup/ext_tables.php
  7. Benni Mack updated the commit message in patch set 3 CR -1 V +1 05/03/23, 09:52

  8. Andreas Kienast commented on patch set 3 07/05/23, 14:21

    Hey folks. I think this patch became obsolete with https://review.typo3.org/c/Packages/TYPO3.CMS/+/78313. Do you agree?
  9. Stefan Bürk abandoned the change 07/06/23, 14:34