Review main Merged

73043[TASK] Avoid StandaloneView() in functional tests

Stefan Bürk CR +2 V +2 Expert +901 −723 updated 01/19/22, 14:35

Commit message

StandaloneView() initalizes an ExtbaseRequest in
__construct() and adds it to the rendering context.

This is unfortunate for ViewHelper tests, since it
hides the information if a specific ViewHelper has
a dependency to a request.

This patch replaces all StandaloneView usages in
functional tests with the TemplateView class of
typo3fluid, which doesn't do anything with request.

When needed, request objects are created and added within
the test manually, making this dependency transparent.

The patch adds some minor refactorings of some tests
along the way and fixes a couple of smaller bugs.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 87

Show 67 more files