Review main Merged

73051[TASK] Refactor ext:scheduler controller and view

Christian Kuhn CR +2 V +2 Nightmare +1807 −1755 updated 01/19/22, 14:38

Commit message

This is a careful rewrite of the scheduler backend
module controller and its view. It reaches a
significantly better separation of concerns between
controller and view.

* The main dispatcher is much more clean and easier to
follow, the methods are smaller and better encapsulated.
* The controller has close to no state except services.
* Improved error handling and notification of edge cases.
* Improved GET/POST separation.
* Better named action and view GET/POST params.
* Improved shortcut namings.
* Minor usability improvements.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 37

Show 17 more files