73052[BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
TYPO3com uploaded patch set 1 01/18/22, 00:06
-
core-ci voted on patch set 1 V +1 01/18/22, 00:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22207
-
Stefan Bürk commented on patch set 1 01/18/22, 07:46
Typo, should be [BUGFIX]ContentObjectRenderer.php:1254My first thought was, that his is superflous because $content is type casted in L1207. Instead of adding the typecast here, we schould add this to cast the returns in L1279 - or better check all possible methods to return alwas a string. -
Stefan Bürk uploaded patch set 2 01/18/22, 23:10
-
Stefan Bürk commented on patch set 2 V +1 CR +1 01/18/22, 23:11
Reply
DoneContentObjectRenderer.php:1254ReplyDone -
core-ci voted on patch set 2 V +1 01/18/22, 23:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22238
-
Oliver Klee voted on patch set 2 CR +1 01/18/22, 23:40
-
Christian Kuhn commented on patch set 2 CR -1 01/19/22, 00:38
ContentObjectRenderer.php:1254i'd prefer to have the string cast here (near the sink), not in line 1279 - just to make sure this is side effect free. -
Stefan Bürk uploaded patch set 3 01/19/22, 13:12
-
Stefan Bürk commented on patch set 3 01/19/22, 13:13
ContentObjectRenderer.php:1254ReplyDone -
Oliver Klee voted on patch set 3 CR +1 01/19/22, 13:15
-
core-ci voted on patch set 3 V +1 01/19/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22266
-
Stefan Bürk voted on patch set 3 V +1 CR +1 01/19/22, 13:22
-
Christian Kuhn voted on patch set 3 V +2 CR +2 01/19/22, 13:57
-
Christian Kuhn merged patch set 4 01/19/22, 13:57