Review main Merged

73071[BUGFIX] Cleanup missed removal of unused variable in ShortcutController

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 01/19/22, 19:24

Commit message

ShortcutController has recieved an modernization overhaul
and shifted data changing actions from 'GET' and 'POST'
handling to 'POST' handling only through #96519, which
removed '$queryParameters' variable populated with 'GET'
parameters from the request in method 'addAction()'.

However removing usage of this variable in a value
fallback chain has been missed, which is now removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1