Review main Merged

73096[BUGFIX] Replace undefined variable with reading PageTSConfig option

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 01/20/22, 11:01

Commit message

Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentElementWizard.override'
option with #70055 over streamlining the TSConfig api (#85016), a lot
of stations in between which already broke reading that option, which
was used for adding the 'new record button', this was refactored into
a dedicated 'createAddButtonForTable()' method with #94456, ending up
with even more broken code and leaving an undefined variable $tsConfig.

Instead of removing the unused variable we load the pageTs here to be
able to read this option again and restore the intended behaviour.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 4

Files 1